Switch from node-sass to sass #1215
Merged
+222
−1,067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-sass is deprecated and doesn't work on newer platforms (e.g. arm64)
intrip
force-pushed
the
switch-to-sass
branch
from
7d48cb4 to
903b51f
Compare
intrip
changed the title
intrip
changed the title
|
I noticed this broke |
intrip
pushed a commit
that referenced
this pull request
Dec 17, 2024
#1215 indirectly removed the --watch mode, by switching compilation to a node.js file. Unfortunatelym `sass` CLI doesn't support a `--function` option, so this was the only option. Now reintroduce `--watch` option using `chokidar`.
intrip
pushed a commit
that referenced
this pull request
Dec 17, 2024
#1215 indirectly removed the `--watch` mode, by switching SCSS compilation to a node.js file. This was required because the `sass` CLI doesn't support a `--function` option to pass custom functions. Now reintroduce it back using `chokidar`. This also fixes `yarn start` command.
intrip
pushed a commit
that referenced
this pull request
Dec 17, 2024
#1215 indirectly removed the `--watch` mode, by switching SCSS compilation to a node.js file. This was required because the `sass` CLI doesn't support the `--function` for custom functions. Now reintroduce it back using `chokidar`. This also fixes `yarn start` command.
intrip
pushed a commit
that referenced
this pull request
Dec 17, 2024
#1215 indirectly removed the `--watch` mode, by switching SCSS compilation to a node.js file. This was required because the `sass` CLI doesn't support the `--function` for custom functions. Now reintroduce it back using `chokidar`. This also fixes `yarn start` command.
Fix: #1216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-sassis deprecated and doesn't work on newer platforms (e.g. arm64)I compared the new
trix.csswith the previous one and haven't noticed any difference besides formatting and two details:@charset "UTF-8";color: rgb(0, 0, 0)instead ofcolor: black